Repository navigation
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds a cross-platform anonymous-analytics opt-out that changes persisted settings, environment synchronization, and server telemetry buffering and delivery behavior. An unresolved Medium-severity finding also indicates queued events may survive an opt-out and be sent after re-enabling telemetry. Not approved because:
Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
wukko
force-pushed
the
analytics-toggle
branch
from
October 7, 2026 07:44
4b7275e to
67426a9
Compare
wukko
marked this pull request as draft
October 7, 2026 07:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Anonymous analytics could only be disabled through an environment variable. Users should also be able to opt out from desktop, web, and mobile settings without restarting the server.
Change
Adds an
Anonymous analyticstoggle under Privacy in desktop/web General settings and mobile Maintenance settings.The setting persists per environment and disables both server analytics and client usage events sent through the server. Buffered events and retries are discarded while disabled. Re-enabling resumes collection without replaying discarded events.
T3CODE_TELEMETRY_ENABLED=falsestill takes precedence. When it forces analytics off, the toggle is disabled and shows a notice. Selecting environments with different override states shows a disabled mixed control.Analytics remain enabled by default.
Scope and approval
This configures the existing analytics capability, which already supports an environment-variable opt-out. The setting controls that same collection and delivery behavior without adding new collection, changing which events are collected, or changing the default.
Closes #4123.
Follow-up to the analytics disclosure fixes in #16563, #16564, and #16565.
Verification
176 tests passed, covering persistence, settings sharing, opt-out, discarded queues and retries, and re-enabling. Server, web, and mobile typechecks passed. Formatting and targeted lint passed with existing lint warnings.
Tested the toggle in the web client and iOS simulator. Mobile changes persisted on the server and appeared immediately in the web client. Checked enabled, disabled, mixed, and overridden states, including the disabled controls and override notices.
Desktop and native iOS builds passed, along with iOS/Android JavaScript exports. Android was not built natively or tested on a device.
Screenshots
Desktop
Before
Enabled
Overridden by an environment variable
Mixed override across environments
Mobile
Before
Enabled
Overridden by an environment variable
Mixed override across environments
Model and harness
Implemented with GPT-6 Astra and GPT-6.1-Sol. Both used the Codex harness.