Repository navigation
Conversation
Run JavaScript and native tests on Windows 2025 with Clang and Temporal. Cache compiler outputs with ccache on main and pull requests targeting main, using the Visual Studio compiler selected by vcbuild. Assisted-by: pi Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Renegade334
reviewed
Oct 1, 2026
| path: ${{ env.CCACHE_DIR }} | ||
| key: windows-2025-${{ runner.arch }}-ccache-v1-${{ env.CCACHE_VERSION }}-${{ github.sha }} | ||
| restore-keys: | | ||
| windows-2025-${{ runner.arch }}-ccache-v1-${{ env.CCACHE_VERSION }}- |
Member
There was a problem hiding this comment.
This would cause havoc with our cache limits. Every new build is going to attempt to save a new bundled-up copy of the entire cache, with no deduplication. I don't know exactly how large the ccache for a Windows build is, but it'll only take (20GB ÷ cache size) builds for the entire repo's GHA cache to be evicted.
sccache does release win32 builds, although I don't know whether it supports the clang-cl masquerading.
Remove the ccache-based compiler cache from the Windows build and test workflow. Saving the bundled cache on every build would quickly exhaust the repository's GitHub Actions cache limits, as raised in review. Assisted-by: pi Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run JavaScript and native tests on Windows 2025 with Clang and Temporal. Cache compiler outputs with ccache on main and pull requests targeting main, using the Visual Studio compiler selected by vcbuild.
AI generated, reviewed by me.