Skip to content

[v24.x] deps: backport V8 prototype retention fixes - #66089

Open
inoway46 wants to merge 2 commits into
nodejs:v24.x-stagingfrom
inoway46:codex/backport-66053-v24
Open

[v24.x] deps: backport V8 prototype retention fixes#66089
inoway46 wants to merge 2 commits into
nodejs:v24.x-stagingfrom
inoway46:codex/backport-66053-v24

Conversation

@inoway46

@inoway46 inoway46 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Fixes: #66053

Backport two V8 fixes:

Adapt to V8 13.6 APIs, add MapRef::is_extensible(), and increment v8_embedder_string per backport.

The reproduction hits OOM on v24.21.0 but completes with these V8 fixes. Refs:

@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Sep 17, 2026
@inoway46
inoway46 marked this pull request as ready for review September 17, 2026 14:32
verwaest and others added 2 commits October 6, 2026 14:59
@verwaest @inoway46 @aduh95
deps: V8: backport 8901c793e439
4a20358 
Original commit message:

    [compiler] Stop collecting array and object prototypes

    We can check in O(1) whether an object is either Object.prototype or
    Array.prototype by directly comparing it with the objects, so there's
    no need to collect them.

    Change-Id: Iadedf8b05cae3d67191fb4836c186620dc009118
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6487694
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Auto-Submit: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#99894}

Refs: v8/v8@8901c79
Co-authored-by: inoway46 <inoueyuya416@gmail.com>
@schuay @inoway46 @aduh95
deps: V8: backport c3553509f460
7511323 
Original commit message:

    [compiler] Thread-safe IsArrayOrObjectPrototype

    Bug: 467311868
    Change-Id: I574aa62d859030545e6a52d693a61e570381e557
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7460949
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#104707}

Refs: v8/v8@c355350
Co-authored-by: inoway46 <inoueyuya416@gmail.com>
@aduh95
aduh95 force-pushed the codex/backport-66053-v24 branch from 39c0466 to 7511323 Compare October 6, 2026 13:00
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 6, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 6, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78211/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7414/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7414/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/7414/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7414/

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78232/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@inoway46 @nodejs-github-bot @aduh95 @verwaest @schuay