Repository navigation
sessions: Add setting for separate sidebar navigation - #340160
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoOct 6, 2026
Merged
Sandeep Somavarapu (sandy081) merged 2 commits into
Sandeep Somavarapu (sandy081) merged 2 commits into
Conversation
Allow users to override the existing navigation experiment through sessions.sidebar.separateNavigation. Keep Automations in the sessions tree when separate navigation is disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
October 6, 2026 22:09
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
October 6, 2026 22:09
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scoped changes use existing configuration infrastructure and focused regression coverage, with no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a user-selectable sidebar layout to the Agents window while retaining experiment-controlled defaults.
Changes:
- Registers
sessions.sidebar.separateNavigationand applies setting changes live. - Supports Automations placement, activation, and focus in both layouts.
- Replaces experiment-state tests with configuration and navigation coverage.
Tests were not rerun during this review.
| File | Description |
|---|---|
src/vs/sessions/contrib/sessions/test/browser/sessionsSidebarNavigation.test.ts |
Tests registration, override precedence, and live updates. |
src/vs/sessions/contrib/sessions/test/browser/sessionsListRearrangeExperiment.test.ts |
Removes obsolete experiment-state tests. |
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts |
Extends Automations placement and interaction coverage. |
src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts |
Observes the setting to update presentation. |
src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts |
Supports Automations in either navigation location. |
src/vs/sessions/contrib/sessions/browser/sessionsListRearrangeExperiment.ts |
Removes the dedicated experiment-state implementation. |
src/vs/sessions/contrib/sessions/browser/sessions.contribution.ts |
Registers the experiment-backed setting. |
src/vs/sessions/common/sessionConfig.ts |
Defines shared setting and treatment identifiers. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Register the production configuration explicitly when earlier tests have cleared the shared registry, and restore its prior registration state afterward. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
roblourens
approved these changes
Oct 6, 2026
Sandeep Somavarapu (sandy081)
deleted the
agents/add-a-setting-to-control-rearranging-sessions-li
branch
October 6, 2026 23:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
sessions.sidebar.separateNavigationso users can choose the sidebar layout instead of relying solely on the existing experiment.falsewith the standard window scope. Explicit user/workspace values override experiment defaults.sessions.list.rearragetreatment through the configuration experiment infrastructure and applies changes live.Validation
npm run compile— passed.npm run hygiene— passed.npm run typecheck-client— passed../scripts/test.sh --run src/vs/sessions/contrib/sessions/test/browser/sessionsSidebarNavigation.test.ts— passed, 4 tests including the registry sanity check../scripts/test.sh --run src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts --run src/vs/sessions/contrib/sessions/test/browser/sessionsViewPane.test.ts— passed, 228 tests.Manual testing
In the Agents window with Automations enabled, toggle
sessions.sidebar.separateNavigationbetweenfalseandtrue. Verify the placements described above and that Automations opens from either layout. Reset the setting to return to the experiment-controlled default.