fix: memory leak in notebookCellLinkifier

[Simon Siefke (SimonSiefke)]

Details

Repeated notebook cell lookups register the same workspace listeners again because the initialized flag is never set.

Change

Set the initialized flag, clear old cell IDs when rebuilding the index, and remove notebook entries when they close.

Before

Across 37 chat responses with three notebook cell links each, clearing chat after every response, named-function-count3 detects +111 per notebook callback. The red box marks rows with reduced growth after the fix.

After

Callback growth drops to +37 per callback. A separate leak remains: each response creates a linkifier that stays until feature deactivation (+37 instances).

Test Video

notebook-cell-links.mp4

_{AI disclosure: Model: Some kind of OpenAI model. Worktime: n/a}

[Copilot]

Copilot review overview

🟡 Changes recommended

The last-notebook close path bypasses the newly added WeakMap cleanup.

Review effort: Balanced
Findings: 1

Open (1)

• Clean up WeakMap entry when the last notebook closes · New

What changed in this PR

Fixes repeated notebook listener registration and stale cell-ID tracking.

Changes:

• Initializes listeners once per linkifier.
• Clears stale IDs and removes closed notebook entries.
• Adds listener lifecycle coverage.

File	Description
notebookCellLinkifier.ts	Updates listener and cell-ID lifecycle cleanup.
notebookCellLinkifier.spec.ts	Tests listener registration and disposal.

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.