Repository navigation
Use attention terminology for agent sessions - #340118
Open
Elijah King (eli-w-king) wants to merge 3 commits into
Open
Elijah King (eli-w-king) wants to merge 3 commits into
Elijah King (eli-w-king) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 432c14b-6dd4-4870-ad94-34607f43292c
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Some user-visible settings retain the old terminology, and related documentation and fixture metadata are now stale.
Review effort: Balanced
Findings: 5
Open (5)
What changed in this PR
Updates agent-session UI terminology from input-centric wording to attention-centric wording across the workbench and Agents window.
Changes:
- Replaces session status, notification, filter, hover, and accessibility copy.
- Uses the warning-colored report icon while preserving attention pulses.
- Updates related unit and component tests.
| File | Description |
|---|---|
test/componentFixtures/playwright/tests/sessionsListTwistie.spec.ts |
Expects report icons and updated ARIA text. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts |
Updates terminal attention notification copy. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionsDataSource.test.ts |
Verifies the report status icon. |
src/vs/workbench/contrib/chat/browser/voiceClient/voiceSessionController.ts |
Updates voice fallback wording. |
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Updates chat setting descriptions. |
src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts |
Updates session-count tooltips. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts |
Changes status icon and labels. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsFilter.ts |
Renames the status filter. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionHoverWidget.ts |
Updates hover status text. |
src/vs/workbench/contrib/agentsVoice/browser/components/statusRowsComponent.ts |
Updates voice status-row copy. |
src/vs/sessions/test/browser/sessionStatusIcon.test.ts |
Tests the pulsing report icon. |
src/vs/sessions/test/browser/sessionConversationGroups.test.ts |
Updates conversation-label expectations. |
src/vs/sessions/services/sessions/test/common/session.test.ts |
Updates status-message expectations. |
src/vs/sessions/services/sessions/test/browser/sessionsListModelService.test.ts |
Tests report icon selection. |
src/vs/sessions/services/sessions/common/session.ts |
Updates the default status message. |
src/vs/sessions/services/sessions/browser/sessionsListModelService.ts |
Selects the warning report icon. |
src/vs/sessions/contrib/sessions/test/browser/sessionsWindowNotifier.test.ts |
Updates notification expectations. |
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts |
Updates icon and accessibility assertions. |
src/vs/sessions/contrib/sessions/electron-browser/sessions.contribution.ts |
Updates application-badge setting copy. |
src/vs/sessions/contrib/sessions/browser/views/sessionsView.ts |
Renames the Sessions status filter. |
src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts |
Updates section ARIA labels. |
src/vs/sessions/contrib/sessions/browser/sessionsWindowNotifier.ts |
Updates OS notification messages. |
src/vs/sessions/contrib/sessions/browser/sessionsTitleBarWidget.ts |
Renames the bulk-ignore command. |
src/vs/sessions/contrib/sessions/browser/sessionsActions.ts |
Updates picker grouping text. |
src/vs/sessions/contrib/sessions/browser/blockedSessionsList.ts |
Updates blocked-session headings and actions. |
src/vs/sessions/contrib/chat/test/browser/openSessionLinkOpener.test.ts |
Updates chat-link presentation expectations. |
src/vs/sessions/common/contextkeys.ts |
Updates context-key documentation. |
src/vs/sessions/browser/sessionStatusIcon.ts |
Replaces the attention spinner with a pulsing report icon. |
src/vs/sessions/browser/sessionConversationGroups.ts |
Updates conversation status labels. |
src/vs/platform/agentHost/test/common/openSessionLink.test.ts |
Updates session-link expectations. |
src/vs/platform/agentHost/common/openSessionLink.ts |
Updates session-link status text. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Preserve upstream filter changes and existing pulse animations; update new status labels and their expectations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 432c14b-6dd4-4870-ad94-34607f43292c
Update remaining user-facing terminology, stale accessibility expectations, fixture metadata, and CI screenshot hashes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 432c14b-6dd4-4870-ad94-34607f43292c
Elijah King (eli-w-king)
requested review from
Benjamin Christopher Simmonds (benibenj) and
Sandeep Somavarapu (sandy081)
October 6, 2026 21:09
Elijah King (eli-w-king)
marked this pull request as ready for review
October 6, 2026 21:13
Elijah King (eli-w-king)
enabled auto-merge
October 6, 2026 21:13
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
Anthony Kim (@anthonykim1)Matched files:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run transpile-clientBefore / After
Demo
The demo cycles through Working, Needs Attention, Completed, and Failed in both the editor and Agents window while preserving the existing Needs Attention pulse.
session-states-demo.mp4