Repository navigation
test(langgraph, litellm, litestar, mcp, openai, openai_agents, pyramid, requests, rq, starlette, starlite, stdlib, strawberry, wsgi): Remove redundant empty data_collection from sentry_init - #7908
Conversation
Codecov Results 📊✅ 55394 passed | ⏭️ 2727 skipped | Total: 58121 | Pass Rate: 95.31% | Execution Time: 152m 25s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2061 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.37% 90.03% -0.34%
==========================================
Files 202 185 -17
Lines 26547 20670 -5877
Branches 9852 7114 -2738
==========================================
+ Hits 23990 18609 -5381
- Misses 2557 2061 -496
- Partials 1496 1215 -281Generated by Codecov Action |
There was a problem hiding this comment.
shouldn't this one also be removed?
There was a problem hiding this comment.
There are still some remaining data_collection={} usages in test_pyramid.py and test_wsgi.py. Should we remove these as well, since the empty config. is now equivalent to the default?
There was a problem hiding this comment.
Great catches 🎣 I missed searching for that permutation of data_collection={}, yes they should be removed!
|
For the rest, LGTM! I found some other test files that had some redundant inits as well: #7910 |
…d, requests, rq, starlette, starlite, stdlib, strawberry, wsgi): Remove redundant empty `data_collection` from sentry_init
An empty `data_collection={}` is equivalent to the default, so passing it
in these tests is redundant.
Refs PY-2936
…n={}` from tests (#7910)
Refs PY-2936
0cbc5b1 to
91035b4
Compare
2 participants
Refs PY-2936