refactor(fastapi): use a global dependency for active thread tracking by faizansaiyed123 · Pull Request #7826 · getsentry/sentry-python

faizansaiyed123 · 2026-10-02T03:19:26Z

Follow-up to #7825.

This PR replaces FastAPI's private routing.get_request_handler monkey patch with an application-level global dependency.

Changes:

Patch FastAPI.__init__ to register a Sentry global dependency before user-supplied global dependencies.
Use Starlette's HTTPConnection injection so the dependency is safe for FastAPI versions where global dependencies also apply to WebSockets.
Move FastAPI-specific transaction naming and http.route setup into the dependency, using FastAPI's effective route context when available.
Install the Starlette sync-handler wrapper on the request's Dependant so synchronous endpoints update thread metadata in their actual worker thread.
Preserve FastAPI request event processing and streamed request-body handling inside the global dependency.
Preserve user-supplied global dependencies.
Remove the private get_request_handler patch.

This branch includes #7825 so it can be reviewed end-to-end. Once #7825 is merged, this PR can be rebased/simplified to the dependency-only diff.

cursor

Stale Bugbot comment from a previous run.

cursor

Stale Bugbot comment from a previous run.

cursor

Stale Bugbot comment from a previous run.

cursor

Stale Bugbot comment from a previous run.

faizansaiyed123 · 2026-10-02T05:57:06Z

cursor review

faizansaiyed123 · 2026-10-02T05:57:19Z

bugbot run verbose=true

cursor · 2026-10-02T05:57:22Z

Bugbot request id: 8939ba6b-1511-41cb-8bd6-5514646cb90c

cursor

Stale Bugbot comment from a previous run.

cursor · 2026-10-02T05:57:28Z

Bugbot rules debug

No rules were used for this review.

https://cursor.com/docs/bugbot#team-rules

Bugbot request id: 8939ba6b-1511-41cb-8bd6-5514646cb90c

cursor

Stale Bugbot comment from a previous run.

sentrivana · 2026-10-07T10:34:44Z

Hey @faizansaiyed123, can you please update your PR now with the current master now that we've merged the thread change?

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 3c15006. Configure here.}

faizansaiyed123 · 2026-10-07T12:45:16Z

@sentrivana Updated the PR with the current master after #7825 was merged. I also addressed the duplicate Starlette patching issue found by Bugbot. Thanks for the guidance!

faizansaiyed123 requested a review from a team as a code owner October 2, 2026 03:19

cursor Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/fastapi.py Outdated

Comment thread sentry_sdk/integrations/fastapi.py

Comment thread sentry_sdk/integrations/fastapi.py

cursor Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/fastapi.py

Comment thread sentry_sdk/integrations/fastapi.py

cursor Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/fastapi.py

faizansaiyed123 force-pushed the fix/7753-fastapi-global-dependency branch from ffa6378 to c428c6e Compare October 2, 2026 05:45

cursor Bot reviewed Oct 2, 2026

View reviewed changes

Comment thread tests/integrations/fastapi/test_fastapi.py Outdated

cursor Bot reviewed Oct 2, 2026

View reviewed changes

faizansaiyed123 added 17 commits October 7, 2026 17:09

refactor(fastapi): register active thread dependency globally

3c93394

refactor(fastapi): remove private request handler patch

1b09b1b

test(fastapi): cover global dependency websocket compatibility

2f20f37

style(fastapi): tidy global dependency setup

ed2f825

test(fastapi): preserve user global dependencies

1544170

test(fastapi): fix global dependency test placement

14696bb

refactor(fastapi): move request setup into global dependency

74f7ec2

style(fastapi): tidy global dependency signature

1a75d1d

fix(fastapi): preserve sync endpoint thread tracking

ead2b68

fix(fastapi): wrap effective route dependant

9521334

fix(fastapi): use effective dependant for sync routes

ecb4063

test(fastapi): cover sync thread tracking in prefixed routes

0359de4

style(fastapi): format thread metadata assertion

8902d6b

refactor(fastapi): restore request lifecycle in global dependency

45318ba

refactor(fastapi): simplify request event processor helper

c06dae1

test(fastapi): cover dependency order and request data

5010b81

test(fastapi): enable tracing for dependency order check

d1861c9

faizansaiyed123 added 9 commits October 7, 2026 17:15

test(fastapi): cover dependency order and request data

cbd4e1b

fix(fastapi): fall back to the routed dependant

2422497

test(fastapi): cover request data on all supported versions

d5f1df7

fix(fastapi): install request isolation with integration

40fe65d

test(fastapi): isolate request event processors

d0b5310

fix(starlette): reuse ASGI instrumentation for FastAPI

18fb09b

test(fastapi): verify request processor cleanup

33d32a4

sync starlette integration with verified PR state

7165336

sync fastapi tests with verified PR state

3c15006

faizansaiyed123 force-pushed the fix/7753-fastapi-global-dependency branch from 1e3d9c2 to 3c15006 Compare October 7, 2026 11:56

cursor Bot reviewed Oct 7, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/fastapi.py

fix(starlette): prevent duplicate patching

15198cf

Conversation

faizansaiyed123 commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

faizansaiyed123 commented Oct 2, 2026

Uh oh!

faizansaiyed123 commented Oct 2, 2026

Uh oh!

cursor Bot commented Oct 2, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot commented Oct 2, 2026

Bugbot rules debug

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sentrivana commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

faizansaiyed123 commented Oct 7, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

faizansaiyed123 commented Oct 2, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

sentrivana commented Oct 7, 2026 •

edited

Loading