Repository navigation
test(node): Port Anthropic integration tests to span streaming - #25082
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
![cursor[bot]](https://github.com/_p/avatars/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 550ecdf. Configure here.
Co-Authored-By: GPT-6 <codex@openai.com>
… spans Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 6, 2026 11:59
nicohrubec
requested review from
isaacs and
mydea
and removed request for
a team
October 6, 2026 11:59
nicohrubec
marked this pull request as draft
October 6, 2026 11:59
nicohrubec
marked this pull request as ready for review
October 6, 2026 12:05
Lms24
approved these changes
Oct 6, 2026
| dataCollection: { genAI: { inputs: false, outputs: false } }, | ||
| transport: loggingTransport, | ||
| beforeSendTransaction: event => { | ||
| // Filter out mock express server transactions |
Member
There was a problem hiding this comment.
Good to be removed without ignoreSpans replacement?
Member
Author
There was a problem hiding this comment.
yes should be good. this was needed to ignore transactions that we don't assert on. this PR changes the pattern a bit to accumulate arriving spans across envelopes and only fails if the assertions don't hold across all incoming spans. drawback of this pattern is that the runner in the failure case won't be giving us nice assertion failures anymore (instead it times out because it never knows if the correct spans might still come). if this gets annoying we might have to fix this in the runner, haven't found a cleaner solution yet.
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the Anthropic integration suites to default span streaming. Remove the redundant streaming-only test and duplicate initialization files; no static coverage is added.
Part of #24138