Repository navigation
docs: record the shader and background-cache fixes on a Mac mini M1 - #985
EtienneLescot wants to merge 1 commit into
Conversation
…i M1 rc.12 at 1.134x the local floor, main 0624c14 at 1.066x in the same session. Metal output differs from rc.12 by 1/255 on anti-aliased edges and by a few pixels on the 3D models' silhouettes, measured losslessly. Adds a Partial row to the manual e2e results log.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe documentation records Mac mini M1 results for Metal rendering changes, including benchmark measurements, export differences, preview checks, and test coverage. It also clarifies which related D3D11 changes remain unmeasured. ChangesMetal rendering measurements
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR records scoped M1 results and keeps the remaining D3D11 gaps explicit. No concrete issue requiring resolution before merge is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Records the Metal half of the export regression fix (#982, #983, #984) on a Mac mini M1. Docs only.
rendering-performance.md: new subsection "The same fixes on Metal: Mac mini M1, 2026-10-03" under the Linux export path, and the Known gaps bullet narrowed to D3D11.manual-e2e-checklist.md: onePartialrow.Results
0624c148Same session, closing control flat (18.18 / 18.19 s). main's
crates/,src/andelectron/are identical to 2.0.0-rc.13. 1.11.0-rc.1 was not re-measured: its run went bad when a Parsec session went live, so the reference stays the published 1.04×.cargo test -p openscreen-compositor --lib --testson the M1: 407 passed, 0 failed,every_shader_entry_point_compileswithLAYER_MODELSincluded.ffv1candidate, measurement only): luma within 1/255 on anti-aliased edges, a few silhouette pixels of the 3D models up to 20/255. Not byte-identical like Linux: Metal fast math and the separate models library.Not covered: computer-use input (nobody at the machine), recording, HUD, tray, Windows, Linux.
Summary by CodeRabbit