Repository navigation
fbc: read tool output with LINE INPUT - #482
Open
metaneutrons wants to merge 1 commit into
Open
metaneutrons wants to merge 1 commit into
metaneutrons wants to merge 1 commit into
Conversation
The compiler reads what a toolchain binary prints with INPUT, which is meant for data records: it ends the field at the first comma and strips surrounding quotes. A path such as /opt/toolchains/gcc,15/lib/libgcc.a comes back as /opt/toolchains/gcc, and the remainder stays in the pipe, so a following read returns the wrong line. Both readers are affected. hGet1stOutputLineFromCommand() feeds the gold-linker probe, and fbcQueryCC() answers -print-libgcc-file-name, whose result goes straight onto the link line. Measured against realistic tool output, INPUT returns /Users/me/My SDKs/MacOSX.sdk unharmed, so spaces are not the problem; commas and quotes are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LINE INPUTinstead of record-orientedINPUTVerification