Skip to content

fix: port the #343 tensormap drain to the SM120 k_grouped NT contiguous kernel #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aganhui wants to merge 1 commit into
base: nv_dev
Choose a base branch
from
Open

fix: port the #343 tensormap drain to the SM120 k_grouped NT contiguous kernel #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions deep_gemm/include/deep_gemm/impls/sm120_fp8_fp4_gemm_1d1d.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,13 @@ sm120_fp8_fp4_gemm_1d1d_impl(cd_dtype_t* gmem_d, const cd_dtype_t* gmem_c,
smem_tm_b, scheduler.current_shape_k, b_new_stride);
}

// Make sure the tensor maps are not used by in-flight TMA loads before updating GMEM
cute::tma_desc_commit_group();
cute::tma_desc_wait_group();
// Only used to prevent `ptxas` from moving the following GMEM stores before `cute::tma_desc_wait_group()`.
// Shouldn't be needed otherwise, since we only use one thread
__syncwarp(1u << lane_idx);

*gmem_tm_a = *smem_tm_a;
*gmem_tm_b = *smem_tm_b;
ptx::tensor_map_release_gpu();
Expand Down