Repository navigation
[Ubuntu 26.04] Keep /tmp on the root disk - #14814
Open
v-davit-ioramashvili wants to merge 1 commit into
Open
v-davit-ioramashvili wants to merge 1 commit into
v-davit-ioramashvili wants to merge 1 commit into
Conversation
Mask tmp.mount so /tmp is not a RAM-backed tmpfs (actions#14777).
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The filesystem test uses positional findmnt, causing it to pass without examining /tmp once /tmp is no longer a mountpoint.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Keeps Ubuntu 26.04 /tmp on the root filesystem to prevent tmpfs quota failures.
Changes:
- Masks
tmp.mounton Ubuntu 26.04. - Adds Pester validation for the mask and filesystem type.
| File | Description |
|---|---|
images/ubuntu/scripts/build/configure-environment.sh |
Masks tmp.mount on Ubuntu 26.04. |
images/ubuntu/scripts/tests/System.Tests.ps1 |
Tests the resulting /tmp configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| It "/tmp is not mounted as tmpfs" { | ||
| & findmnt -n -o FSTYPE /tmp | Should -Not -Be "tmpfs" |
v-sergei-pyshnoi
approved these changes
Sep 29, 2026
5 of 21 tasks
v-AndriiKhyliuk
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fixing.
Ubuntu 26.04 mounts
/tmpas a tmpfs by default (up to 50% of RAM, with a per-user quota), so large builds fail with "disk quota exceeded" once/tmpfills up. This maskstmp.mounton 26.04 so/tmpstays on the root disk, like on 24.04, and adds a test for it.Tested on a rebooted 26.04 VM with the same mask-then-reboot order as the image build, and with the reporter's failing build.
Related issue:
#14777
Check list