Skip to content

check-shims: Avoid building full DSL RBI trees when their scopes cannot overlap shims - #2734

Draft
KaanOzkan wants to merge 1 commit into
mainfrom
ko-check-shims-scope-prefilter
Draft

KaanOzkan wants to merge 1 commit into
mainfrom
ko-check-shims-scope-prefilter

Conversation

@KaanOzkan

Copy link
Copy Markdown
Contributor

Motivation

Part of #2728

Implementation

check-shims now builds full RBI trees only for DSL files whose scopes could overlap with shims. On Shopify Core, a one-worker run fell from 56.38s to 37.10s. Focused tests and typecheck pass.

Tests

@KaanOzkan
KaanOzkan force-pushed the ko-check-shims-scope-prefilter branch from d13b35c to 5627c80 Compare October 5, 2026 20:29
@KaanOzkan
KaanOzkan force-pushed the ko-check-shims-scope-prefilter branch from 5627c80 to 2f0a2ba Compare October 5, 2026 21:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant