Skip to content

Agent skills reference a non-existent CLI path and two skills that don't exist #4000

Description

@AryanKansagara

The agent skills in .claude/skills/ contain three stale references that send contributors (and coding agents reading them) to paths and skills that do not exist. All three are present on main as of b543c6d2.

1. Wrong path for the Hydrogen CLI source

.claude/skills/hydrogen-dev-workflow/SKILL.md:132 states:

The Hydrogen CLI source code lives at packages/cli-hydrogen in the Hydrogen repo.

There is no packages/cli-hydrogen directory. The CLI source lives at packages/cli; @shopify/cli-hydrogen is only the npm package name (packages/cli/package.json → "name": "@shopify/cli-hydrogen").

This is the single most-consulted line in the skill for anyone touching CLI code, and it is the one line that is wrong. An agent following it runs ls packages/cli-hydrogen, gets ENOENT, and starts guessing at the layout.

2. Two dangling skill references

Both skills point readers at skills that do not exist anywhere in this repo:

File Line Dangling reference(s)
.claude/skills/hydrogen-dev-workflow/SKILL.md 14 headless-storefronts-context, shopify-repos
.claude/skills/hydrogen-versioning/SKILL.md 15 headless-storefronts-context

.claude/skills/ contains exactly four skills — e2e-test-writing, hydrogen-dev-workflow, hydrogen-release-process, hydrogen-versioning. Neither headless-storefronts-context nor shopify-repos is among them, and neither exists as a command in .claude/commands/. They appear to be leftovers from an internal Shopify skill set that was not vendored into the public repo.

The cost is small but real: an agent told "see the shopify-repos skill for repo locations" will either burn a turn searching for it, or treat the missing context as something it must reconstruct itself.

Expected Behavior

Skills reference paths and sibling skills that actually exist in the repo.

Actual Behavior

Three references resolve to nothing. Verified against main at b543c6d2:

$ grep -rn "headless-storefronts-context\|shopify-repos" .claude/
.claude/skills/hydrogen-versioning/SKILL.md:15:...see `headless-storefronts-context`.
.claude/skills/hydrogen-dev-workflow/SKILL.md:14:...see the `headless-storefronts-context` skill. For repo locations, see the `shopify-repos` skill.

$ ls .claude/skills/
e2e-test-writing  hydrogen-dev-workflow  hydrogen-release-process  hydrogen-versioning

$ ls packages/
cli  create-hydrogen  hydrogen  hydrogen-codegen  hydrogen-react  mini-oxygen  remix-oxygen

Steps to Reproduce

  1. Check out main.
  2. Run the three commands above from the repo root.
  3. Observe that packages/cli-hydrogen, headless-storefronts-context, and shopify-repos do not exist.

Related (not fixed here)

packages/cli/package.json carries the same stale directory name in its repository block:

"repository": {
  "type": "git",
  "url": "git+https://github.com/Shopify/hydrogen.git",
  "directory": "packages/cli-hydrogen"
}

This makes the "Repository" link on the npm page for @shopify/cli-hydrogen point at a non-existent subdirectory. I left it out of the accompanying PR deliberately: it touches packages/*/package.json, so it trips the changeset requirement and would turn a docs-only change into a version-bumping one. Happy to send it as a separate PR with a patch changeset if the team wants it.

I have a PR ready for items 1 and 2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions