Repository navigation
Keep JSON prompts and concurrent process output on stderr - #8804
Open
isaacroldan wants to merge 1 commit into
Open
isaacroldan wants to merge 1 commit into
isaacroldan wants to merge 1 commit into
Conversation
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/ui/components/ConcurrentOutput.d.ts@@ -1,4 +1,4 @@
-import { OutputProcess } from '../../../../public/node/output.js';
+import { type OutputProcess } from '../../../../public/node/output.js';
import { AbortSignal } from '../../../../public/node/abort.js';
import { FunctionComponent } from 'react';
export interface ConcurrentOutputProps {
@@ -14,6 +14,8 @@ interface ConcurrentOutputContext {
stripAnsi?: boolean;
}
declare function useConcurrentOutputContext<T>(context: ConcurrentOutputContext, callback: () => T): T;
+/** Runs finite processes concurrently and routes their output through the shared diagnostic context. */
+export declare function runConcurrentProcessesForJson({ processes, abortSignal, }: Pick<ConcurrentOutputProps, 'processes' | 'abortSignal'>): Promise<void>;
/**
* Renders output from concurrent processes to the terminal.
* Output will be divided in a three column layout
|
1 of 4 tasks
isaacroldan
added this pull request to stack #8805
October 6, 2026 16:32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Interactive prompts and concurrent process output can write terminal text to stdout in JSON mode, which prevents commands from returning one parseable JSON document.
This is the shared UI prerequisite for #8801.
WHAT is this pull request doing?
Send finite concurrent process output as JSON diagnostic and progress events to stderr. Send interactive UI to stderr in JSON mode while preserving input policy and streaming behavior.
How to manually test your changes?
With dependent PR #8801 checked out, use a disposable local app with installed dependencies:
shopify app build --path <app> --skip-dependencies-installation --json --no-input > build.json 2> build.events.jsonl. Check that stdout contains one result and build output appears as events on stderr.--no-input. Select a config and check that the prompt appears on stderr while stdout remains valid JSON.--jsonand check that normal build output remains.Validation
70 focused UI tests passed, including existing task and concurrent-output tests. CLI Kit build, type checks, scoped lint, and Knip passed. Full CI and other operating systems were not run locally.
Checklist