Skip to content

chore(query): improve filter string kernel - #9965

Merged
bohutang merged 3 commits into
databendlabs:mainfrom
sundy-li:string-3
Feb 10, 2023
Merged

bohutang merged 3 commits into
databendlabs:mainfrom
sundy-li:string-3

Conversation

@sundy-li

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #issue

@sundy-li
sundy-li requested a review from andylokandy February 10, 2023 09:07
@vercel

vercel Bot commented Feb 10, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
databend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 9:10AM (UTC)

@mergify mergify Bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 10, 2023
@bohutang

Copy link
Copy Markdown
Member

How much performance has been improved?

@sundy-li

sundy-li commented Feb 10, 2023 •

Copy link
Copy Markdown
Member Author

How much performance has been improved?

It's just a little better. StringColumn method index_unchecked will call AsRef each time. This pr avoids it.

Comment thread src/query/expression/src/kernels/filter.rs
@bohutang
bohutang merged commit 8618fb5 into databendlabs:main Feb 10, 2023

This branch was previously deployed

1 inactive deployment
Preview — 571e505e Deployed Feb 10, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-chore this PR only has small changes that no need to record, like coding styles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants