refactor(dedup): reduce code duplication from 97 to 10 groups

Eliminated 89 duplicate groups (-2807 lines) across 4 parallel fixer batches:
- Centralized VulnerabilityFinding construction and inline blocks
- Extracted shared test helpers (create_test_finding, create_test_config, fixtures)
- Consolidated internal duplicates in llm.rs, llm_metrics.rs, tickets/, indexer.rs, agent/executor.rs, root_cause_dedup.rs, phase/helpers.rs
- Removed production<->test mirror groups where safe

CI gate: fmt clean, clippy clean, 2395 tests pass.
Final state: 10 groups / 631 lines (0.6%) — meets ≤10 target.

Author: Mte90

Cargo.lock

@@ -183,8 +183,30 @@ mod tests {
     use crate::agent::sandbox::ToolSandbox;
     use crate::agent::tool_schema::ToolRegistry;
     use crate::agent::ToolCall;
+    use crate::llm::{ChatMessage, ChatResponse};
     use std::sync::Arc;
 
+    async fn setup_tool_execution_test(
+        registry: &ToolRegistry,
+        sandbox: &ToolSandbox,
+        response: &ChatResponse,
+        messages: Vec<ChatMessage>,
+        progress_cb: &ProgressCallback,
+        tmpdir_path: &std::path::Path,
+    ) -> (Vec<String>, Option<std::path::PathBuf>, Option<std::path::PathBuf>, Vec<ChatMessage>) {
+        execute_tool_calls(
+            registry,
+            sandbox,
+            response,
+            messages,
+            progress_cb,
+            tmpdir_path,
+            1,
+            10,
+            "Turn",
+        )
+        .await
+    }
     #[test]
     fn test_create_empty_finding() {
         let finding = create_empty_finding(
@@ -271,18 +293,14 @@ mod tests {
 
         let messages = vec![ChatMessage::user("test")];
 
-        let (tools_used, test_path, compile_path, messages) = execute_tool_calls(
+        let (tools_used, test_path, compile_path, messages) = setup_tool_execution_test(
             &registry,
             &sandbox,
             &response,
             messages,
             &progress_cb,
             tmpdir.path(),
-            1,
-            10,
-            "Turn",
-        )
-        .await;
+        ).await;
 
         assert_eq!(tools_used, vec!["file_read".to_string()]);
         assert!(test_path.is_none());
@@ -560,18 +578,14 @@ mod tests {
 
         let messages = vec![ChatMessage::user("test")];
 
-        let (tools_used, test_path, compile_path, messages) = execute_tool_calls(
+        let (tools_used, test_path, compile_path, messages) = setup_tool_execution_test(
             &registry,
             &sandbox,
             &response,
             messages,
             &progress_cb,
             tmpdir.path(),
-            1,
-            10,
-            "Turn",
-        )
-        .await;
+        ).await;
 
         assert!(tools_used.is_empty());
         assert!(test_path.is_none());